linux-kernel - Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77a40d03-6c31-4db2-ae5e-c5fc33a7142c@nxp.com>
Date: Fri, 18 Oct 2024 14:58:47 +0800
From: Liu Ying <victor.liu@....com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Biju Das <biju.das.jz@...renesas.com>
Cc: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 "rfoss@...nel.org" <rfoss@...nel.org>,
 "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
 "jonas@...boo.se" <jonas@...boo.se>,
 "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
 "airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch"
 <simona@...ll.ch>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>,
 "catalin.marinas@....com" <catalin.marinas@....com>,
 "will@...nel.org" <will@...nel.org>,
 "quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
 "geert+renesas@...der.be" <geert+renesas@...der.be>,
 "arnd@...db.de" <arnd@...db.de>,
 "nfraprado@...labora.com" <nfraprado@...labora.com>,
 "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
 "y.moog@...tec.de" <y.moog@...tec.de>, "marex@...x.de" <marex@...x.de>,
 "isaac.scott@...asonboard.com" <isaac.scott@...asonboard.com>
Subject: Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

On 10/14/2024, Dmitry Baryshkov wrote:
> On Sun, Oct 13, 2024 at 10:48:54AM +0000, Biju Das wrote:

[...]

>>>>> +static int it6263_bridge_attach(struct drm_bridge *bridge,
>>>>> +				enum drm_bridge_attach_flags flags) {
>>>>> +	struct it6263 *it = bridge_to_it6263(bridge);
>>>>> +	int ret;
>>>>> +
>>>>> +	ret = drm_bridge_attach(bridge->encoder, it->next_bridge, bridge,
>>>>> +				flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>>>>> +	if (ret < 0)
>>>>> +		return ret;
>>>>> +
>>>>> +	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>>>>> +		return 0;
>>>>> +
>>>>> +	it->connector.polled = DRM_CONNECTOR_POLL_CONNECT |
>>>>> +			       DRM_CONNECTOR_POLL_DISCONNECT;
>>>>> +
>>>>
>>>> Please strongly consider dropping this and using drm_bridge_connector
>>>> in the host driver.
>>>
>>> I can't afford to make i.MX8MP imx-lcdif KMS use drm_bridge_connector currently.  Maybe the Renesas
>>> RZ/G3E SMARC EVK Biju tested v1 patch set with is also not using drm_bridge_connector.  I hope we can
>>> leave it as-is for now.
>>
>> Renesas platform use the drm_bridge_connector_init() helper to create a drm_connector for
>> each output, instead of relying on the bridge drivers doing so. It attach
>> the bridges with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to instruct
>> them not to create a connector.
>>
>> On Renesas platform, it exit from here
>> if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>> 	return 0;
>>
>> Maybe it is good to have both cases to start with. Add support for both cases now,
>> Later when imx-lcdif KMS start using drm_bridge_connector,
>> we can start dropping bridge devices to create connector??
> 
> Do we have a timeline for this?

I sent out a patch series to make i.MX LCDIF driver use
drm_bridge_connector just now.
https://patchwork.freedesktop.org/series/140148/

-- 
Regards,
Liu Ying