linux-kernel - RE: [PATCH net v2 0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <ZQZPR01MB097931B757AB6481F16BE2D58A402@ZQZPR01MB0979.CHNPR01.prod.partner.outlook.cn>
Date: Fri, 18 Oct 2024 08:59:51 +0000
From: Leyfoon Tan <leyfoon.tan@...rfivetech.com>
To: Simon Horman <horms@...nel.org>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lftan.linux@...i.com" <lftan.linux@...i.com>
Subject: RE: [PATCH net v2 0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Thursday, October 17, 2024 10:10 PM
> To: Leyfoon Tan <leyfoon.tan@...rfivetech.com>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; lftan.linux@...i.com
> Subject: Re: [PATCH net v2 0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4
> 
> On Wed, Oct 16, 2024 at 11:18:28AM +0800, Ley Foon Tan wrote:
> > This patch series fix the bugs in dwmac4 drivers.
> >
> > Changes since v1:
> > - Removed empty line between Fixes and Signoff
> > - Rebased to
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> > - Updated git commit description for patch 4/4
> >
> > History:
> > v1:
> > https://patchwork.kernel.org/project/netdevbpf/cover/20241015065708.34
> > 65151-1-leyfoon.tan@...rfivetech.com/
> 
> Hi,
> 
> Thanks for the update and sorry for not providing more timely feedback.
> 
> I think that the code changes themselves look fine. However, as a rule of
> thumb, fixes for net should resolve user-visible problems.
> I see that is the case for patch 4/4, but it is less clear to me for the other 3
> patches. If it is indeed then I think it would be good to explain that more
> clearly in their patch descriptions.
> 
> If not, perhaps they should be submitted to net-next without Fixes tags while
> patch 4 and any others that are still fixes resubmitted as a smaller
> v3 patch-set for net.
> 
> ...

Patch 1-3 no user-visible problem so far.
Patch 1-3 will submit to net-next, and Patch 4 will submit to net.

Regards
Ley Foon