[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4127b448-a914-4c69-b938-29512995326f@amlogic.com>
Date: Fri, 18 Oct 2024 17:01:09 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Jerome Brunet <jbrunet@...libre.com>,
Krzysztof Kozlowski <krzk@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Amlogic A4
SoCs
Hi Jerome,
Thanks for your reply.
On 2024/10/18 16:39, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
>
> On Fri 18 Oct 2024 at 10:28, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
>> On 18/10/2024 10:10, Xianwei Zhao via B4 Relay wrote:
>>> From: Xianwei Zhao <xianwei.zhao@...ogic.com>
>>>
>>> Add the new compatible name for Amlogic A4 pin controller, and add
>>> a new dt-binding header file which document the detail pin names.
>
> the change does not do what is described here. At least the description
> needs updating.
>
Will do.
> So if the pin definition is now in the driver, does it mean that pins have
> to be referenced in DT directly using the made up numbers that are
> created in pinctrl-amlogic-a4.c at the beginning of patch #2 ?
>
Yes.
> If that's case, it does not look very easy a read.
>
It does happen. The pin definition does not fall under the category of
binding.
https://lore.kernel.org/all/106f4321-59e8-49b9-bad3-eeb57627c921@amlogic.com/
>>>
>>> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> Best regards,
>> Krzysztof
>
> --
> Jerome
Powered by blists - more mailing lists