linux-kernel - Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com>
Date: Fri, 18 Oct 2024 12:52:15 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Wu Hao <hao.wu@...el.com>, Tom Rix
 <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, Xu Yilun
 <yilun.xu@...el.com>,  Linus Walleij <linus.walleij@...aro.org>, Bartosz
 Golaszewski <brgl@...ev.pl>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Richard
 Cochran <richardcochran@...il.com>, Damien Le Moal <dlemoal@...nel.org>,
 Hannes Reinecke <hare@...e.de>, Chaitanya Kulkarni <kch@...dia.com>,  Al
 Viro <viro@...iv.linux.org.uk>, Li Zetao <lizetao1@...wei.com>,
 linux-block@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-fpga@...r.kernel.org,  linux-gpio@...r.kernel.org,
 netdev@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions()

On Wed, 2024-10-16 at 13:38 +0300, Andy Shevchenko wrote:
> On Wed, Oct 16, 2024 at 11:49:05AM +0200, Philipp Stanner wrote:
> > pcim_ionumap_region() has recently been made a public function and
> > does
> > not have the disadvantage of having to deal with the legacy iomap
> > table,
> > as pcim_iounmap_regions() does.
> > 
> > Deprecate pcim_iounmap_regions().
> 
> ...
> 
> > + * This function is DEPRECATED. Do not use it in new code.
> 
> Interestingly that the syntax of the DEPRECATED is not documented
> (yet?),
> however the sphinx parser hints us about **DEPRECATED** format — see
> Documentation/sphinx/parse-headers.pl:251. In any case the above
> seems
> like second used (in a form of the full sentence) and will be updated
> in accordance with the above mentioned script.

Can't completely follow – so one should always write "**DEPRECATED**",
correct?

Is that a blocker for you?

All the docstrings in pci/pci.c and pci/devres.c so far just use
"DEPRECATED".

P.