[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5175d8a9b007ce1c6c12bcc09d78dfda@manjaro.org>
Date: Fri, 18 Oct 2024 12:52:35 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Frank Wang <frawang.cn@...il.com>
Cc: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de,
linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, william.wu@...k-chips.com,
tim.chen@...k-chips.com, yubing.zhang@...k-chips.com, Frank Wang
<frank.wang@...k-chips.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf
syscon
Hello Frank,
On 2024-10-18 09:34, Frank Wang wrote:
> On 2024/10/18 14:37, Dragan Simic wrote:
>> On 2024-10-18 08:18, Frank Wang wrote:
>>> On 2024/10/18 13:02, Dragan Simic wrote:
>>>> On 2024-10-17 04:52, Frank Wang wrote:
>>>>> From: Frank Wang <frank.wang@...k-chips.com>
>>>>>
>>>>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>>>>> configured in usbdp phy driver.
>>>>>
>>>>> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
>>>>> ---
>>>>> Changelog:
>>>>> v2:
>>>>> - This is a new patch adds rk3576-vo1-grf syscon.
>>>>
>>>> Could you, please, clarify a bit why is this additional patch
>>>> needed in this series?
>>>
>>> I mentioned in the commit content. The usbdp-phy driver select dp
>>> lanes via configuring the vo1-grf.
>>
>> Yes, I already saw that in the patch description. Though, and
>> I apologize if I'm missing something obvious, I can't see where
>> is it actually used in the code? Is it yet to be used in the
>> dts(i) files?
>>
>> I'd appreciate if you could clarify that just a bit further, so
>> I can hopefully understand it better.
>
> Yes, the usbdp_phy node in dts(i) will assign the vo1-grf phandle like
> this:
>
> usbdp_phy: phy@...10000 {
> ...
> rockchip,vo-grf = <&vo1_grf>;
> };
>
> And the usbdp-phy driver parses it and assign to udphy->vogrf, it uses
> in rk_udphy_dplane_select().
>
> The related codes have already existed in the current driver, so for
> RK3576, just only need to do a configuration.
Great, thanks for the detailed explanation! This confirms
my latest assumption and everything is looking good, so please
free to include:
Reviewed-by: Dragan Simic <dsimic@...jaro.org>
>>>>> v1:
>>>>> - none
>>>>>
>>>>> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git
>>>>> a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> index 50d727f4b76c6..fd42217ab85e7 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> @@ -33,6 +33,7 @@ properties:
>>>>> - rockchip,rk3576-usb-grf
>>>>> - rockchip,rk3576-usbdpphy-grf
>>>>> - rockchip,rk3576-vo0-grf
>>>>> + - rockchip,rk3576-vo1-grf
>>>>> - rockchip,rk3576-vop-grf
>>>>> - rockchip,rk3588-bigcore0-grf
>>>>> - rockchip,rk3588-bigcore1-grf
>>>>> @@ -283,6 +284,7 @@ allOf:
>>>>> compatible:
>>>>> contains:
>>>>> enum:
>>>>> + - rockchip,rk3576-vo1-grf
>>>>> - rockchip,rk3588-vo-grf
>>>>> - rockchip,rk3588-vo0-grf
>>>>> - rockchip,rk3588-vo1-grf
Powered by blists - more mailing lists