linux-kernel - [PATCH] 9p/trans_usbg: Fix incorrect error check in usb9pfs_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241019092302.212221-1-yuehaibing@huawei.com>
Date: Sat, 19 Oct 2024 17:23:02 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: <ericvh@...nel.org>, <lucho@...kov.net>, <asmadeus@...ewreck.org>,
	<linux_oss@...debyte.com>, <m.grzeschik@...gutronix.de>,
	<yuehaibing@...wei.com>, <gregkh@...uxfoundation.org>
CC: <v9fs@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] 9p/trans_usbg: Fix incorrect error check in usb9pfs_alloc_instance()

kzalloc() should use NULL check not a IS_ERR() check.

Fixes: a3be076dc174 ("net/9p/usbg: Add new usb gadget function transport")
Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
---
 net/9p/trans_usbg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/9p/trans_usbg.c b/net/9p/trans_usbg.c
index 975b76839dca..6b694f117aef 100644
--- a/net/9p/trans_usbg.c
+++ b/net/9p/trans_usbg.c
@@ -909,9 +909,9 @@ static struct usb_function_instance *usb9pfs_alloc_instance(void)
 	usb9pfs_opts->buflen = DEFAULT_BUFLEN;
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-	if (IS_ERR(dev)) {
+	if (!dev) {
 		kfree(usb9pfs_opts);
-		return ERR_CAST(dev);
+		return ERR_PTR(-ENOMEM);
 	}
 
 	usb9pfs_opts->dev = dev;
-- 
2.34.1