linux-kernel - Re: [PATCH net,v3] hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241019090601.GQ1697@kernel.org>
Date: Sat, 19 Oct 2024 10:06:01 +0100
From: Simon Horman <horms@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, kys@...rosoft.com,
	wei.liu@...nel.org, decui@...rosoft.com, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, stephen@...workplumber.org,
	davem@...emloft.net, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH net,v3] hv_netvsc: Fix VF namespace also in synthetic NIC
 NETDEV_REGISTER event

On Fri, Oct 18, 2024 at 11:25:22AM -0700, Haiyang Zhang wrote:
> The existing code moves VF to the same namespace as the synthetic NIC
> during netvsc_register_vf(). But, if the synthetic device is moved to a
> new namespace after the VF registration, the VF won't be moved together.
> 
> To make the behavior more consistent, add a namespace check for synthetic
> NIC's NETDEV_REGISTER event (generated during its move), and move the VF
> if it is not in the same namespace.
> 
> Cc: stable@...r.kernel.org
> Fixes: c0a41b887ce6 ("hv_netvsc: move VF to same namespace as netvsc device")
> Suggested-by: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
> v3: Use RCT order as suggested by Simon.
> v2: Move my fix to synthetic NIC's NETDEV_REGISTER event as suggested by Stephen.

Thanks, this looks good to me.