linux-kernel - Re: [PATCH v2 06/10] x86/mce: Convert multiple if () statements into a switch() statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d011a77-a46e-4589-ae91-80d8d29e4124@intel.com>
Date: Fri, 18 Oct 2024 17:04:42 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Tony Luck <tony.luck@...el.com>
CC: Qiuxu Zhuo <qiuxu.zhuo@...el.com>, <bp@...en8.de>, <tglx@...utronix.de>,
	<dave.hansen@...ux.intel.com>, <mingo@...hat.com>, <hpa@...or.com>,
	<x86@...nel.org>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 06/10] x86/mce: Convert multiple if () statements into
 a switch() statement

On 10/18/2024 1:14 PM, Tony Luck wrote:

> The vendor specific bits are large enough to warrant their own
> static functions (as we do elsewhere in this file).
> 
> How about this (only compile-tested) patch?
> 

Yeah, it does make it easier to read. Can some of the hardcoded numbers
be changed to vfm macros as well?