linux-kernel - Re: [PATCH v2 00/10] x86/mce: Clean up some x86/mce code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c88bbbbf-9f49-4ec0-b1af-075ddb85d0cf@intel.com>
Date: Fri, 18 Oct 2024 13:40:10 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>, <tony.luck@...el.com>, <bp@...en8.de>
CC: <tglx@...utronix.de>, <dave.hansen@...ux.intel.com>, <mingo@...hat.com>,
	<hpa@...or.com>, <x86@...nel.org>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 00/10] x86/mce: Clean up some x86/mce code

On 10/16/2024 5:30 AM, Qiuxu Zhuo wrote:

> Qiuxu Zhuo (10):
>   x86/mce/dev-mcelog: Use xchg() to get and clear the flags
>   x86/mce/intel: Use MCG_BANKCNT_MASK instead of 0xff
>   x86/mce: Make several functions return bool
>   x86/mce/threshold: Remove the redundant this_cpu_dec_return()
>   x86/mce/genpool: Make mce_gen_pool_create() return explicit error codes
>   x86/mce: Convert multiple if () statements into a switch() statement
>   x86/mce: Remove the unnecessary {}
>   x86/mce: Remove the redundant zeroing assignments
>   x86/mce/amd: Remove unnecessary NULL pointer initializations
>   x86/mce: Fix typos in comments
> 

Apart from the minor nits and commit message changes, the patches look
fine to me.

With those addressed,
Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>