linux-kernel - Re: [PATCH] xhci: Fix Link TRB DMA in command ring stopped completion event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbfa824b-cb28-40fa-b447-30ed5832fe82@quicinc.com>
Date: Sat, 19 Oct 2024 22:53:17 +0530
From: Faisal Hassan <quic_faisalh@...cinc.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Mathias Nyman <mathias.nyman@...el.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] xhci: Fix Link TRB DMA in command ring stopped completion
 event



On 10/19/2024 12:04 PM, Greg Kroah-Hartman wrote:
> On Sat, Oct 19, 2024 at 01:29:53AM +0530, Faisal Hassan wrote:
>> During the aborting of a command, the software receives a command
>> completion event for the command ring stopped, with the TRB pointing
>> to the next TRB after the aborted command.
>>
>> If the command we abort is located just before the Link TRB in the
>> command ring, then during the 'command ring stopped' completion event,
>> the xHC gives the Link TRB in the event's cmd DMA, which causes a
>> mismatch in handling command completion event.
>>
>> To handle this situation, an additional check has been added to ignore
>> the mismatch error and continue the operation.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Faisal Hassan <quic_faisalh@...cinc.com>
> 
> What commit id does this fix?
> 
> thanks,
> 
> greg k-h

This does not fix any specific commit. It appears that the
implementation has been missing since the very beginning of xhci-ring.c.
Therefore, can I reference the first commit in the Fixes tag:
7f84eef0dafb ("USB: xhci: No-op command queueing and irq handler.")?

Thanks,
Faisal