linux-kernel - Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fbd9ca12f85d28dcc2eed5f0fe9c49762b83a35.camel@infradead.org>
Date: Sat, 19 Oct 2024 18:14:30 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: Paolo Bonzini <pbonzini@...hat.com>, Jonathan Corbet <corbet@....net>, 
 Marc Zyngier <maz@...nel.org>, James Morse <james.morse@....com>, Suzuki K
 Poulose <suzuki.poulose@....com>,  Zenghui Yu <yuzenghui@...wei.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Pavel
 Machek <pavel@....cz>, Len Brown <len.brown@...el.com>, Shuah Khan
 <shuah@...nel.org>,  kvm@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
 kvmarm@...ts.linux.dev,  linux-pm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Francesco Lavra
 <francescolavra.fl@...il.com>, Miguel Luis <miguel.luis@...cle.com>
Subject: Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2

On Tue, 2024-10-15 at 10:16 -0700, Oliver Upton wrote:
> 
> > After looking at this again, I think we should do one of the following:
> > 
> >   - TEST_REQUIRE() that the PSCI version is at least v1.3, making the
> >     dependency clear on older kernels.
> > 
> >   - TEST_REQUIRE() for v1.3, which would provide better test coverage on
> >     upstream.
> 
> Sorry, I meant TEST_ASSERT() here.

Ack. I'll do the latter.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)