[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <da174fe9af56d5c0f77ee140456c9d07cc968136.camel@ew.tq-group.com>
Date: Mon, 21 Oct 2024 16:44:26 +0200
From: Matthias Schiffer <matthias.schiffer@...tq-group.com>
To: Lee Jones <lee@...nel.org>
Cc: linux@...tq-group.com, linux-kernel@...r.kernel.org, Gregor Herburger
<gregor.herburger@...group.com>
Subject: Re: [PATCH v5 5/5] mfd: tqmx86: add I2C IRQ support
On Mon, 2024-10-21 at 13:34 +0200, Matthias Schiffer wrote:
> From: Gregor Herburger <gregor.herburger@...group.com>
>
> The i2c-ocores controller can run in interrupt mode on tqmx86 modules.
> Add module parameter to allow configuring the IRQ number, similar to the
> handling of the GPIO IRQ.
>
> Signed-off-by: Gregor Herburger <gregor.herburger@...group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> ---
>
> v2: improve module parameter description (was patch 4/4)
> v3: replace IRQ 0 resource with an empty placeholder to simplify error handling
> v4: no changes
> v5: move placeholder to the end of the resource array, use define for index
Ugh... I just realized that I forgot to update a comment for v5. Will send a new version some time
this week.
>
> drivers/mfd/tqmx86.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
> index 1fd2212bf492c..94126a484c412 100644
> --- a/drivers/mfd/tqmx86.c
> +++ b/drivers/mfd/tqmx86.c
> @@ -50,6 +50,7 @@
> #define TQMX86_REG_IO_EXT_INT_9 2
> #define TQMX86_REG_IO_EXT_INT_12 3
> #define TQMX86_REG_IO_EXT_INT_MASK 0x3
> +#define TQMX86_REG_IO_EXT_INT_I2C_SHIFT 0
> #define TQMX86_REG_IO_EXT_INT_GPIO_SHIFT 4
> #define TQMX86_REG_SAUC 0x17
>
> @@ -60,11 +61,18 @@ static uint gpio_irq;
> module_param(gpio_irq, uint, 0);
> MODULE_PARM_DESC(gpio_irq, "GPIO IRQ number (valid parameters: 7, 9, 12)");
>
> +static uint i2c_irq;
> +module_param(i2c_irq, uint, 0);
> +MODULE_PARM_DESC(i2c_irq, "I2C IRQ number (valid parameters: 7, 9, 12)");
> +
> /* Index of IRQ placeholder in resource list */
> #define TQMX86_IRQ_GPIO 1
> +#define TQMX86_IRQ_I2C 1
>
> -static const struct resource tqmx_i2c_soft_resources[] = {
> +static struct resource tqmx_i2c_soft_resources[] = {
> DEFINE_RES_IO(TQMX86_IOBASE_I2C, TQMX86_IOSIZE_I2C),
> + /* Placeholder for IRQ resource - filled in by the probe function */
> + [TQMX86_IRQ_I2C] = {},
> };
>
> static const struct resource tqmx_watchdog_resources[] = {
> @@ -262,6 +270,14 @@ static int tqmx86_probe(struct platform_device *pdev)
> ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(dev, board_id);
>
> if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) {
> + if (i2c_irq) {
> + err = tqmx86_setup_irq(dev, "I2C", i2c_irq, io_base,
> + TQMX86_REG_IO_EXT_INT_I2C_SHIFT);
> + if (!err)
> + /* Assumes the IRQ resource placeholder is first */
> + tqmx_i2c_soft_resources[TQMX86_IRQ_I2C] = DEFINE_RES_IRQ(i2c_irq);
> + }
> +
> err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> tqmx86_i2c_soft_dev,
> ARRAY_SIZE(tqmx86_i2c_soft_dev),
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
Powered by blists - more mailing lists