linux-kernel - Re: [PATCH 2/2] Revert "kasan: Disable Software Tag-Based KASAN with GCC"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+fCnZcU1P5RxLmHekgsWGWQZ+oOQQLqH_LC0JxqBtLJqR3c7A@mail.gmail.com>
Date: Mon, 21 Oct 2024 19:13:05 +0200
From: Andrey Konovalov <andreyknvl@...il.com>
To: Marco Elver <elver@...gle.com>
Cc: Will Deacon <will@...nel.org>, Andrey Ryabinin <ryabinin.a.a@...il.com>, 
	Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, 
	Vincenzo Frascino <vincenzo.frascino@....com>, Mark Rutland <mark.rutland@....com>, 
	linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com, 
	llvm@...ts.linux.dev, Andrew Pinski <pinskia@...il.com>
Subject: Re: [PATCH 2/2] Revert "kasan: Disable Software Tag-Based KASAN with GCC"

On Mon, Oct 21, 2024 at 2:00 PM Marco Elver <elver@...gle.com> wrote:
>
> This reverts commit 7aed6a2c51ffc97a126e0ea0c270fab7af97ae18.
>
> Now that __no_sanitize_address attribute is fixed for KASAN_SW_TAGS with
> GCC, allow re-enabling KASAN_SW_TAGS with GCC.
>
> Cc: Andrey Konovalov <andreyknvl@...il.com>
> Cc: Andrew Pinski <pinskia@...il.com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Will Deacon <will@...nel.org>
> Signed-off-by: Marco Elver <elver@...gle.com>
> ---
>  lib/Kconfig.kasan | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan
> index 233ab2096924..98016e137b7f 100644
> --- a/lib/Kconfig.kasan
> +++ b/lib/Kconfig.kasan
> @@ -22,11 +22,8 @@ config ARCH_DISABLE_KASAN_INLINE
>  config CC_HAS_KASAN_GENERIC
>         def_bool $(cc-option, -fsanitize=kernel-address)
>
> -# GCC appears to ignore no_sanitize_address when -fsanitize=kernel-hwaddress
> -# is passed. See https://bugzilla.kernel.org/show_bug.cgi?id=218854 (and
> -# the linked LKML thread) for more details.
>  config CC_HAS_KASAN_SW_TAGS
> -       def_bool !CC_IS_GCC && $(cc-option, -fsanitize=kernel-hwaddress)
> +       def_bool $(cc-option, -fsanitize=kernel-hwaddress)
>
>  # This option is only required for software KASAN modes.
>  # Old GCC versions do not have proper support for no_sanitize_address.
> @@ -101,7 +98,7 @@ config KASAN_SW_TAGS
>         help
>           Enables Software Tag-Based KASAN.
>
> -         Requires Clang.
> +         Requires GCC 11+ or Clang.
>
>           Supported only on arm64 CPUs and relies on Top Byte Ignore.
>
> --
> 2.47.0.rc1.288.g06298d1525-goog
>

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>