linux-kernel - [PATCH v2] sumversion: Fix a memory leak in get_src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241021203846.930-1-esalomatkina@ispras.ru>
Date: Mon, 21 Oct 2024 23:38:46 +0300
From: Elena Salomatkina <esalomatkina@...ras.ru>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Elena Salomatkina <esalomatkina@...ras.ru>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Nicolas Schier <nicolas@...sle.eu>,
	linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: [PATCH v2] sumversion: Fix a memory leak in get_src_version()

strsep() modifies its first argument - buf.
If an error occurs in the parsing loop, an invalid pointer
will be passed to the free() function.
Make the pointer passed to free() match the return value of
read_text_file().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 9413e7640564 ("kbuild: split the second line of *.mod into *.usyms")
Signed-off-by: Elena Salomatkina <esalomatkina@...ras.ru>
---
v2: Rename 'orig' to 'pos'

 scripts/mod/sumversion.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c
index 6bf9caca0968..03774957d8b9 100644
--- a/scripts/mod/sumversion.c
+++ b/scripts/mod/sumversion.c
@@ -385,7 +385,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md)
 /* Calc and record src checksum. */
 void get_src_version(const char *modname, char sum[], unsigned sumlen)
 {
-	char *buf;
+	char *buf, *pos;
 	struct md4_ctx md;
 	char *fname;
 	char filelist[PATH_MAX + 1];
@@ -393,7 +393,7 @@ void get_src_version(const char *modname, char sum[], unsigned sumlen)
 	/* objects for a module are listed in the first line of *.mod file. */
 	snprintf(filelist, sizeof(filelist), "%s.mod", modname);
 
-	buf = read_text_file(filelist);
+	pos = buf = read_text_file(filelist);
 
 	md4_init(&md);
 	while ((fname = strsep(&buf, "\n"))) {
@@ -406,5 +406,5 @@ void get_src_version(const char *modname, char sum[], unsigned sumlen)
 
 	md4_final_ascii(&md, sum, sumlen);
 free:
-	free(buf);
+	free(pos);
 }
-- 
2.33.0