linux-kernel - Re: [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cda71c5-a3c7-46de-a12f-c9c8b2f6de64@suse.de>
Date: Mon, 21 Oct 2024 09:19:46 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Arnd Bergmann <arnd@...nel.org>, Helge Deller <deller@....de>,
 Javier Martinez Canillas <javierm@...hat.com>
Cc: Arnd Bergmann <arnd@...db.de>, linux-fbdev@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS



Am 18.10.24 um 17:12 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@...db.de>
>
> The fb_io_mmap() function is used in the file operations but
> not enabled in all configurations unless FB_IOMEM_FOPS gets
> selected:
>
> ld.lld-20: error: undefined symbol: fb_io_mmap
>>>> referenced by wm8505fb.c
>>>>                drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a
> Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/video/fbdev/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 9957dde4a3f6..961d7f5bbbc2 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1388,6 +1388,7 @@ config FB_VT8500
>   config FB_WM8505
>   	bool "Wondermedia WM8xxx-series frame buffer support"
>   	depends on (FB = y) && HAS_IOMEM && (ARCH_VT8500 || COMPILE_TEST)
> +	select FB_IOMEM_FOPS
>   	select FB_SYS_FILLRECT if (!FB_WMT_GE_ROPS)
>   	select FB_SYS_COPYAREA if (!FB_WMT_GE_ROPS)
>   	select FB_SYS_IMAGEBLIT

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)