linux-kernel - Re: [PATCH] ALSA: hda/tas2781: select CRC32 instead of CRC32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zfmxj4zz.wl-tiwai@suse.de>
Date: Mon, 21 Oct 2024 09:21:20 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-sound@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-kernel@...r.kernel.org,
	Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: select CRC32 instead of CRC32_SARWATE

On Sun, 20 Oct 2024 19:56:24 +0200,
Eric Biggers wrote:
> 
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Fix the kconfig option for the tas2781 HDA driver to select CRC32 rather
> than CRC32_SARWATE.  CRC32_SARWATE is an option from the kconfig
> 'choice' that selects the specific CRC32 implementation.  Selecting a
> 'choice' option seems to have no effect, but even if it did work, it
> would be incorrect for a random driver to override the user's choice.
> CRC32 is the correct option to select for crc32() to be available.
> 
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied now.


Takashi