linux-kernel - Re: [PATCH v2 2/3] platform/x86: intel_scu_ipc: Simplify code with cleanup helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VejavDObi4PMLPVCO==YCTRkOvV-uOOSyx_=74bOSrKxQ@mail.gmail.com>
Date: Mon, 21 Oct 2024 12:42:45 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org>, 
	platform-driver-x86@...r.kernel.org, Andy Shevchenko <andy@...nel.org>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, Hans de Goede <hdegoede@...hat.com>, 
	Ferry Toth <fntoth@...il.com>
Subject: Re: [PATCH v2 2/3] platform/x86: intel_scu_ipc: Simplify code with
 cleanup helpers

On Mon, Oct 21, 2024 at 12:32 PM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:
> On Mon, 21 Oct 2024, Andy Shevchenko wrote:

...

> IMO, this change is doing too many things at once and it's hard to justify
> why those changes must be kept in the same patch. If the guard() change
> is done first and only then the logic reversions, both patches would
> probably be near trivial to review for correctness.

Are you insisting on this?
Because that's how I have done similar changes in the past all over
the kernel, and IIRC you are the first one asking for this :-)

-- 
With Best Regards,
Andy Shevchenko