linux-kernel - Re: [PATCH] selftests/sched: add basic test for psi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241022140556.GB219474@cmpxchg.org>
Date: Tue, 22 Oct 2024 10:05:56 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Pintu Kumar <quic_pintu@...cinc.com>
Cc: shuah@...nel.org, surenb@...gle.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	skhan@...uxfoundation.org, pintu.ping@...il.com
Subject: Re: [PATCH] selftests/sched: add basic test for psi

On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote:
> There is a psi module that exists under kernel/sched/psi.
> Add a basic test to test the psi.

I'm not sure this is a valuable use of test cycles. The mere existence
and basic format of the files is very unlikely to be buggy, and such a
bug wouldn't hide for very long either.

> @@ -18548,10 +18548,12 @@ F:	include/uapi/linux/pps.h
>  PRESSURE STALL INFORMATION (PSI)
>  M:	Johannes Weiner <hannes@...xchg.org>
>  M:	Suren Baghdasaryan <surenb@...gle.com>
> +M:	Pintu Kumar <quic_pintu@...cinc.com>

$ git log --oneline --author='Pintu Kumar' kernel/sched/psi.c | wc -l
0

Really? ;)

>  R:	Peter Ziljstra <peterz@...radead.org>
>  S:	Maintained
>  F:	include/linux/psi*
>  F:	kernel/sched/psi.c
> +F:	tools/testing/selftests/sched/psi_test.c
>  
>  PRINTK
>  M:	Petr Mladek <pmladek@...e.com>