linux-kernel - Re: [PATCH] selftests/sched: add basic test for psi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuPNLg_Y6aNwj8muAWhm7ibcNZ7dp6t57CFKB+oZoV1Ao_xBA@mail.gmail.com>
Date: Tue, 22 Oct 2024 23:53:40 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, shuah@...nel.org, surenb@...gle.com, 
	peterz@...radead.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] selftests/sched: add basic test for psi

Hi Johannes,

On Tue, 22 Oct 2024 at 19:36, Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote:
> > There is a psi module that exists under kernel/sched/psi.
> > Add a basic test to test the psi.
>
> I'm not sure this is a valuable use of test cycles. The mere existence
> and basic format of the files is very unlikely to be buggy, and such a
> bug wouldn't hide for very long either.
>
Yes, I agree this is just a basic version to prepare for the test framework.
Once the framework is available more tests can be added, such as trigger poll.
If you have any other suggestions for the test please let me know.

> > @@ -18548,10 +18548,12 @@ F:  include/uapi/linux/pps.h
> >  PRESSURE STALL INFORMATION (PSI)
> >  M:   Johannes Weiner <hannes@...xchg.org>
> >  M:   Suren Baghdasaryan <surenb@...gle.com>
> > +M:   Pintu Kumar <quic_pintu@...cinc.com>
>
> $ git log --oneline --author='Pintu Kumar' kernel/sched/psi.c | wc -l
> 0
>
> Really? ;)
>
oh sorry.
This maintainer was added for tools/testing/sefttests/sched/psi_test
after referring to existing once.
Otherwise, checkpatch was giving below warning:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51:
new file mode 100644
total: 0 errors, 1 warnings, 134 lines checked

Please let me know what is the correct way.

Thanks,
Pintu