linux-kernel - Re: [PATCH v9 24/37] common: Enable BLOBLIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLszTiWxQjjfg4ydQDEOH2-J0_7O5rYNowFPPJB9w86QY3gXw@mail.gmail.com>
Date: Tue, 22 Oct 2024 19:00:49 +0200
From: Simon Glass <sjg@...omium.org>
To: Patrick Rudolph <patrick.rudolph@...ements.com>
Cc: Peter Robinson <pbrobinson@...il.com>, u-boot@...ts.denx.de, 
	linux-kernel@...r.kernel.org, Tom Rini <trini@...sulko.com>
Subject: Re: [PATCH v9 24/37] common: Enable BLOBLIST_TABLES on arm

Hi Patrick,

On Tue, 22 Oct 2024 at 18:18, Patrick Rudolph
<patrick.rudolph@...ements.com> wrote:
>
> Hi Simon,
> On Tue, Oct 22, 2024 at 2:16 PM Simon Glass <sjg@...omium.org> wrote:
> >
> > Hi Peter,
> >
> > On Mon, 21 Oct 2024 at 19:57, Peter Robinson <pbrobinson@...il.com> wrote:
> > >
> > > > > > > Allow to use BLOBLIST_TABLES on arm to store ACPI or other tables.
> > > > > > >
> > > > > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> > > > > > > Cc: Tom Rini <trini@...sulko.com>
> > > > > > > ---
> > > > > > > Changelog v9:
> > > > > > > - default to BLOBLIST_ALLOC on arm
> > > > > > > - Move default for BLOBLIST_SIZE_RELOC up
> > > > > > > ---
> > > > > > >  common/Kconfig |  2 ++
> > > > > > >  lib/Kconfig    | 15 +++++++++------
> > > > > > >  2 files changed, 11 insertions(+), 6 deletions(-)
> > > > > > >
> > > > > >
> > > > > > This is fine, but please disable it for snow since it needs the FIXED
> > > > > > option for now.
> > > > >
> > > > > I cannot follow. What needs the FIXED option and what to disable?
> > > > > I run this patch on the CI and test_py_sandbox tests are still working.
> > > >
> > > > I mean that snow cannot use BLOBLIST_ALLOC and needs BLOBLIST_FIXED so
> > > > if you make ALLOC the default you need to change the default for snow.
> > >
> > > Simon by snow do you mean the device (configs/snow_defconfig) snow, I
> > > think Patrick doesn't know you're referring to what I believe to be a
> > > device config.
> >
> > Oh OK, yes that is what I mean. If it is too confusing I can send a
> > fix-up patch after this series is applied.
> >
> Oh OK, got it.
> I wasn't aware that BLOBLIST is already used on some ARM devices.
> I'll send an updated version.
> Is it possible to migrate those to BLOBLIST_ALLOC? Any reason they
> would use a fixed address?

Not easily, since it puts the table in SRAM. But it would be possible
to migrate snow to use the handle protocol.

Regards,
Simon