linux-kernel - Re: [PATCH] RAS/AMD/ATL: Add debug prints for DF register reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241022170303.GLZxfax_-72ZCX1I_q@fat_crate.local>
Date: Tue, 22 Oct 2024 19:03:03 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: tony.luck@...el.com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, avadhut.naik@....com,
	john.allen@....com
Subject: Re: [PATCH] RAS/AMD/ATL: Add debug prints for DF register reads

On Mon, Oct 21, 2024 at 03:21:58PM +0000, Yazen Ghannam wrote:
> The ATL will fail early if the DF register access fails due to missing
> PCI IDs in the amd_nb code. There aren't any clear indicators on why the
> ATL will fail to load in this case.
> 
> Add a couple of debug print statements to highlight reasons for failure.
> 
> A common scenario is missing support for new hardware. If the ATL fails
> to load on a system, and there is interest to support it, then dynamic
> debugging can be enabled to help find the cause for failure. If there is
> no interest in supporting ATL on a new system, then these failures will
> be silent.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> ---
>  drivers/ras/amd/atl/access.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette