lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241022180620.12429-1-m.omerfarukbulut@gmail.com>
Date: Tue, 22 Oct 2024 21:06:20 +0300
From: Omer Faruk BULUT <m.omerfarukbulut@...il.com>
To: dpenkler@...il.com
Cc: gregkh@...uxfoundation.org,
	arnd@...db.de,
	linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Omer Faruk BULUT <m.omerfarukbulut@...il.com>
Subject: [PATCH] Staging: gpib/common/gpib_os.c - Remove unnecessary OOM message

It duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning.

    WARNING: Possible unnecessary 'out of memory' message

Also, this patch itself might teach to module writers or readers that they have to give attention to MM subsystem
even they interest another one.

Signed-off-by: Omer Faruk BULUT <m.omerfarukbulut@...il.com>
---
 drivers/staging/gpib/common/gpib_os.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index 6b12404efe7d..27654b2180a5 100644
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -2093,10 +2093,9 @@ void gpib_register_driver(gpib_interface_t *interface, struct module *provider_m
 	struct gpib_interface_list_struct *entry;
 
 	entry = kmalloc(sizeof(*entry), GFP_KERNEL);
-	if (!entry) {
-		pr_err("gpib: failed register %s interface, out of memory\n", interface->name);
+	if (!entry) 
 		return;
-	}
+	
 	entry->interface = interface;
 	entry->module = provider_module;
 	list_add(&entry->list, &registered_drivers);
-- 
2.17.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ