linux-kernel - RE: [PATCH next] wifi: rtw89: unlock on error path in rtw89_ops_unassign_vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a80d4adc51f4ea884b5e02f16d8aaed@realtek.com>
Date: Tue, 22 Oct 2024 03:27:03 +0000
From: Zong-Zhe Yang <kevin_yang@...ltek.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Ping-Ke Shih <pkshih@...ltek.com>, Kalle Valo <kvalo@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] wifi: rtw89: unlock on error path in rtw89_ops_unassign_vif_chanctx()

Dan Carpenter <dan.carpenter@...aro.org> wrote:
> 
> [...]
>
> @@ -1373,6 +1373,7 @@ static void rtw89_ops_unassign_vif_chanctx(struct ieee80211_hw
> *hw,
> 
>         rtwvif_link = rtwvif->links[link_conf->link_id];
>         if (unlikely(!rtwvif_link)) {
> +               mutex_unlock(&rtwdev->mutex);
>                 rtw89_err(rtwdev,
>                           "%s: rtwvif link (link_id %u) is not active\n",
>                           __func__, link_conf->link_id);
>

Acked-by: Zong-Zhe Yang <kevin_yang@...ltek.com>

Thanks