linux-kernel - RE: [PATCH next] wifi: rtw89: unlock on error path in rtw89_ops_unassign_vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <931c79c15bc04be99bb87a9826cf2b04@realtek.com>
Date: Tue, 22 Oct 2024 03:32:23 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Zong-Zhe Yang <kevin_yang@...ltek.com>,
        Dan Carpenter
	<dan.carpenter@...aro.org>
CC: Kalle Valo <kvalo@...nel.org>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] wifi: rtw89: unlock on error path in rtw89_ops_unassign_vif_chanctx()

Zong-Zhe Yang <kevin_yang@...ltek.com> wrote:
> Dan Carpenter <dan.carpenter@...aro.org> wrote:
> >
> > [...]
> >
> > @@ -1373,6 +1373,7 @@ static void rtw89_ops_unassign_vif_chanctx(struct ieee80211_hw
> > *hw,
> >
> >         rtwvif_link = rtwvif->links[link_conf->link_id];
> >         if (unlikely(!rtwvif_link)) {
> > +               mutex_unlock(&rtwdev->mutex);
> >                 rtw89_err(rtwdev,
> >                           "%s: rtwvif link (link_id %u) is not active\n",
> >                           __func__, link_conf->link_id);
> >
> 
> Acked-by: Zong-Zhe Yang <kevin_yang@...ltek.com>
> 

Thanks for the ack. 

Acked-by is often used by the maintainer, so I will change it to Reviewed-by
during committing.