| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <bcb28a623f51f077367e6c1f4382d1a43b6c2ee7.camel@mediatek.com>
Date: Tue, 22 Oct 2024 05:30:49 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
"christian.koenig@....com" <christian.koenig@....com>, "mchehab@...nel.org"
<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Shu-hsiang Yang (楊舒翔)
<Shu-hsiang.Yang@...iatek.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"yunkec@...omium.org" <yunkec@...omium.org>, "linaro-mm-sig@...ts.linaro.org"
<linaro-mm-sig@...ts.linaro.org>, "linux-media@...r.kernel.org"
<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, Yaya Chang (張雅清)
<Yaya.Chang@...iatek.com>, Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "hidenorik@...omium.org"
<hidenorik@...omium.org>, Shun-Yi Wang (王順億)
<Shun-Yi.Wang@...iatek.com>
Subject: Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility
Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@...iatek.com>
> ---
[snip]
> +/*
> + * A U T O W H I T E B A L A N C E
> + */
> +
> +/* Maximum blocks that MediaTek AWB supports */
> +#define MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM (10)
> +
> +/*
> + * struct mtk_cam_uapi_awb_param - parameters for AWB configurtion
> + *
> + * @stat_en: AWB stat enable
> + * @windownum_x: Number of horizontal AWB windows
> + * @windownum_y: Number of vertical AWB windows
> + * @lowthreshold_r: Low threshold of R
> + * @lowthreshold_g: Low threshold of G
> + * @lowthreshold_b: Low threshold of B
> + * @highthreshold_r: High threshold of R
> + * @highthreshold_g: High threshold of G
> + * @highthreshold_b: High threshold of B
> + * @lightsrc_lowthreshold_r: Low threshold of R for light source estimation
> + * @lightsrc_lowthreshold_g: Low threshold of G for light source estimation
> + * @lightsrc_lowthreshold_b: Low threshold of B for light source estimation
> + * @lightsrc_highthreshold_r: High threshold of R for light source estimation
> + * @lightsrc_highthreshold_g: High threshold of G for light source estimation
> + * @lightsrc_highthreshold_b: High threshold of B for light source estimation
> + * @pregainlimit_r: Maximum limit clipping for R color
> + * @pregainlimit_g: Maximum limit clipping for G color
> + * @pregainlimit_b: Maximum limit clipping for B color
> + * @pregain_r: unit module compensation gain for R color
> + * @pregain_g: unit module compensation gain for G color
> + * @pregain_b: unit module compensation gain for B color
> + * @valid_datawidth: valid bits of statistic data
> + * @hdr_support_en: support HDR mode
> + * @stat_mode: Output format select <1>sum mode <0>average mode
> + * @error_ratio: Programmable error pixel count by AWB window size
> + * (base : 256)
> + * @awbxv_win_r: light area of right bound, the size is defined in
> + * MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM
> + * @awbxv_win_l: light area of left bound the size is defined in
> + * MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM
> + * @awbxv_win_d: light area of lower bound the size is defined in
> + * MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM
> + * @awbxv_win_u: light area of upper bound the size is defined in
> + * MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM
> + * @pregain2_r: white balance gain of R color
> + * @pregain2_g: white balance gain of G color
> + * @pregain2_b: white balance gain of B color
> + */
> +struct mtk_cam_uapi_awb_param {
> + u32 stat_en;
> + u32 windownum_x;
windownum_x is useless, so drop it.
Regards,
CK
> + u32 windownum_y;
> + u32 lowthreshold_r;
> + u32 lowthreshold_g;
> + u32 lowthreshold_b;
> + u32 highthreshold_r;
> + u32 highthreshold_g;
> + u32 highthreshold_b;
> + u32 lightsrc_lowthreshold_r;
> + u32 lightsrc_lowthreshold_g;
> + u32 lightsrc_lowthreshold_b;
> + u32 lightsrc_highthreshold_r;
> + u32 lightsrc_highthreshold_g;
> + u32 lightsrc_highthreshold_b;
> + u32 pregainlimit_r;
> + u32 pregainlimit_g;
> + u32 pregainlimit_b;
> + u32 pregain_r;
> + u32 pregain_g;
> + u32 pregain_b;
> + u32 valid_datawidth;
> + u32 hdr_support_en;
> + u32 stat_mode;
> + u32 format_shift;
> + u32 error_ratio;
> + u32 postgain_r;
> + u32 postgain_g;
> + u32 postgain_b;
> + u32 postgain2_hi_r;
> + u32 postgain2_hi_g;
> + u32 postgain2_hi_b;
> + u32 postgain2_med_r;
> + u32 postgain2_med_g;
> + u32 postgain2_med_b;
> + u32 postgain2_low_r;
> + u32 postgain2_low_g;
> + u32 postgain2_low_b;
> + s32 awbxv_win_r[MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM];
> + s32 awbxv_win_l[MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM];
> + s32 awbxv_win_d[MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM];
> + s32 awbxv_win_u[MTK_CAM_UAPI_AWB_MAX_LIGHT_AREA_NUM];
> + u32 csc_ccm[9];
> + u32 acc;
> + u32 med_region[4];
> + u32 low_region[4];
> + u32 pregain2_r;
> + u32 pregain2_g;
> + u32 pregain2_b;
> +} __packed;
> +
Powered by blists - more mailing lists