linux-kernel - Re: [PATCH net-next 13/15] dt-bindings: net: add compatible strings for lan969x SKU's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <omfbhkikj6vthkssxcspdatoksifjp6khuxalvyhprijygm2ro@wa2zmixejjgw>
Date: Tue, 22 Oct 2024 08:11:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, andrew@...n.ch, Lars Povlsen <lars.povlsen@...rochip.com>, 
	Steen Hegelund <Steen.Hegelund@...rochip.com>, horatiu.vultur@...rochip.com, 
	jensemil.schulzostergaard@...rochip.com, Parthiban.Veerasooran@...rochip.com, 
	Raju.Lakkaraju@...rochip.com, UNGLinuxDriver@...rochip.com, 
	Richard Cochran <richardcochran@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, jacob.e.keller@...el.com, 
	ast@...erby.net, maxime.chevallier@...tlin.com, netdev@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 13/15] dt-bindings: net: add compatible strings
 for lan969x SKU's

On Mon, Oct 21, 2024 at 03:58:50PM +0200, Daniel Machon wrote:
> Add compatible strings for the twelve different lan969x SKU's (Stock
> Keeping Unit) that we need to support. We need to support all of them,
> as we are going to use them in the driver, for deriving the devicetree
> target in a subsequent patch.
> 
> Also, add myself as a maintainer.
> 
> Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> ---
>  .../bindings/net/microchip,sparx5-switch.yaml           | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> index fcafef8d5a33..c38f0bd9a481 100644
> --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> @@ -9,6 +9,7 @@ title: Microchip Sparx5 Ethernet switch controller
>  maintainers:
>    - Steen Hegelund <steen.hegelund@...rochip.com>
>    - Lars Povlsen <lars.povlsen@...rochip.com>
> +  - Daniel Machon <daniel.machon@...rochip.com>
>  
>  description: |
>    The SparX-5 Enterprise Ethernet switch family provides a rich set of
> @@ -34,7 +35,21 @@ properties:
>      pattern: "^switch@[0-9a-f]+$"
>  
>    compatible:
> -    const: microchip,sparx5-switch
> +    items:
> +      - enum:
> +          - microchip,sparx5-switch

Keep alphabetical order.

> +          - microchip,lan9691-switch
> +          - microchip,lan9692-switch
> +          - microchip,lan9693-switch
> +          - microchip,lan9694-switch
> +          - microchip,lan9695-switch
> +          - microchip,lan9696-switch
> +          - microchip,lan9697-switch
> +          - microchip,lan9698-switch
> +          - microchip,lan9699-switch
> +          - microchip,lan969a-switch
> +          - microchip,lan969b-switch
> +          - microchip,lan969c-switch

All of them use the same match data, so they are compatible? I have
doubts this is necessary in the first place. Your commit description about
driver does not help me. You need them because you are going to use
them? Yeah, it would be surprising otherwise. :)

Best regards,
Krzysztof