[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241022072644.Tw-k3d95@linutronix.de>
Date: Tue, 22 Oct 2024 09:26:44 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
Peter Zijlstra <peterz@...radead.org>, tglx@...utronix.de,
mingo@...nel.org, juri.lelli@...hat.com, vincent.guittot@...aro.org,
dietmar.eggemann@....com, bsegall@...gle.com, mgorman@...e.de,
vschneid@...hat.com, ankur.a.arora@...cle.com, efault@....de,
Masami Hiramatsu <mhiramat@...nel.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v2 2/3] tracing: Record task flag NEED_RESCHED_LAZY.
On 2024-10-22 03:18:27 [-0400], Steven Rostedt wrote:
> On Mon, 21 Oct 2024 17:08:41 +0200
> Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote:
>
> > enum trace_flag_type {
> > TRACE_FLAG_IRQS_OFF = 0x01,
> > TRACE_FLAG_NEED_RESCHED = 0x02,
> > + TRACE_FLAG_NEED_RESCHED_LAZY = 0x04,
> > TRACE_FLAG_HARDIRQ = 0x08,
> > TRACE_FLAG_SOFTIRQ = 0x10,
> > TRACE_FLAG_PREEMPT_RESCHED = 0x20,
>
> As I stated in the other email, these are user visible. Should probably
> make the LAZY flag 0x100, as the trace_flags are 16 bits worth.
What about struct trace_entry? That flags is stored as 8bit in
tracing_generic_entry_update().
>
> -- Steve
Sebastian
Powered by blists - more mailing lists