linux-kernel - Re: [PATCH for-6.12-fixes] sched_ext: fix fmt_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5225d97-115a-4a0f-8ba3-1279407a7002@leemhuis.info>
Date: Tue, 22 Oct 2024 11:58:53 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Andrea Righi <andrea.righi@...ux.dev>, Tejun Heo <tj@...nel.org>,
 David Vernet <void@...ifault.com>
Cc: Kumar Kartikeya Dwivedi <memxor@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-6.12-fixes] sched_ext: fix fmt__str variables in
 kfuncs

On 22.10.24 09:40, Andrea Righi wrote:
> Commit 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in
> kfuncs") renamed some parameters without updating the body of the
> functions, triggering build errors like this:
> 
> kernel/sched/ext.c:6881:45: error: ‘fmt’ undeclared (first use in this function)
> 6881 |       if (bstr_format(&scx_exit_bstr_buf, fmt, data, data__sz) >= 0)
>      |                                             ^~~
> 
> Fix by renaming also the varibles in the affected kfuncs.
> 
> Fixes: 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in kfuncs")

Thx for this: ran into a build error with my daily -next builds earlier
today[1] and this fixes things (it's still compiling, but I'm past the
point where this happened afaics).

Tested-by: Thorsten Leemhuis <linux@...mhuis.info>

Ciao, Thorsten

[1]
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-41-x86_64/08165136-next-next-all/builder-live.log.gz