linux-kernel - Re: [PATCH for-6.12-fixes] sched_ext: fix fmt_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP01T76UiJAPVM1-KaiYyJLgDt37brdDUCT=NLOUxCuG850W-w@mail.gmail.com>
Date: Tue, 22 Oct 2024 12:10:10 +0200
From: Kumar Kartikeya Dwivedi <memxor@...il.com>
To: Andrea Righi <andrea.righi@...ux.dev>
Cc: Tejun Heo <tj@...nel.org>, David Vernet <void@...ifault.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-6.12-fixes] sched_ext: fix fmt__str variables in kfuncs

On Tue, 22 Oct 2024 at 09:40, Andrea Righi <andrea.righi@...ux.dev> wrote:
>
> Commit 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in
> kfuncs") renamed some parameters without updating the body of the
> functions, triggering build errors like this:
>
> kernel/sched/ext.c:6881:45: error: ‘fmt’ undeclared (first use in this function)
> 6881 |       if (bstr_format(&scx_exit_bstr_buf, fmt, data, data__sz) >= 0)
>      |                                             ^~~
>
> Fix by renaming also the varibles in the affected kfuncs.
>
> Fixes: 3e99aee7ce48 ("sched-ext: Use correct annotation for strings in kfuncs")
> Signed-off-by: Andrea Righi <andrea.righi@...ux.dev>
> ---

Ah, thanks, this is embarrassing.
I didn't realize sched-ext was disabled in the .config when testing
this with other patches in the queue.
Sorry about that.

Acked-by: Kumar Kartikeya Dwivedi <memxor@...il.com>