linux-kernel - Re: [PATCH linux-next] drm/i915/dp: use string choice helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r088v3fo.fsf@intel.com>
Date: Tue, 22 Oct 2024 13:26:35 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: R Sundar <prosunofficial@...il.com>, Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 imre.deak@...el.com, ville.syrjala@...ux.intel.com, R Sundar
 <prosunofficial@...il.com>, kernel test robot <lkp@...el.com>, Julia
 Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH linux-next] drm/i915/dp: use string choice helpers

On Mon, 07 Oct 2024, R Sundar <prosunofficial@...il.com> wrote:
> Use str_on_off string helpers for better readability and to fix cocci
> warning.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202410071252.cWILJzrH-lkp@intel.com/
> Signed-off-by: R Sundar <prosunofficial@...il.com>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.

> ---
>
> Reported in linux repo:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> cocci warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_dp.c:2243:6-9: opportunity for str_on_off(dsc)
>
> vim +2243 drivers/gpu/drm/i915/display/intel_dp.c
>
> compile tested only.
>
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index fbb096be02ad..733619b14193 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2475,7 +2475,7 @@ intel_dp_compute_config_link_bpp_limits(struct intel_dp *intel_dp,
>  		    encoder->base.base.id, encoder->base.name,
>  		    crtc->base.base.id, crtc->base.name,
>  		    adjusted_mode->crtc_clock,
> -		    dsc ? "on" : "off",
> +		    str_on_off(dsc),
>  		    limits->max_lane_count,
>  		    limits->max_rate,
>  		    limits->pipe.max_bpp,

-- 
Jani Nikula, Intel