linux-kernel - Re: [PATCH linux-next] drm/i915/ddi: use string choice helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o73cv3f6.fsf@intel.com>
Date: Tue, 22 Oct 2024 13:26:53 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: R Sundar <prosunofficial@...il.com>, Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 imre.deak@...el.com
Cc: R Sundar <prosunofficial@...il.com>, kernel test robot <lkp@...el.com>,
 Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH linux-next] drm/i915/ddi: use string choice helpers

On Mon, 07 Oct 2024, R Sundar <prosunofficial@...il.com> wrote:
> Use str_enabled_disabled string helpers for better readability and to
> fix cocci warning.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202410071601.TFpXoqgW-lkp@intel.com/
> Signed-off-by: R Sundar <prosunofficial@...il.com>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.

> ---
>
> Reported in linux repo:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> cocci warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_ddi.c:2225:7-13: opportunity for str_enabled_disabled(enable)
>
> vim +2225 drivers/gpu/drm/i915/display/intel_ddi.c
>
> compile tested only.
>
>  drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index fe1ded6707f9..ff4c633c8546 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2236,7 +2236,7 @@ static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp,
>  	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_CONFIGURATION,
>  			       enable ? DP_FEC_READY : 0) <= 0)
>  		drm_dbg_kms(display->drm, "Failed to set FEC_READY to %s in the sink\n",
> -			    enable ? "enabled" : "disabled");
> +			    str_enabled_disabled(enable));
>  
>  	if (enable &&
>  	    drm_dp_dpcd_writeb(&intel_dp->aux, DP_FEC_STATUS,

-- 
Jani Nikula, Intel