linux-kernel - Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dnri3nqq2una3atjwl437ujzrl2txl2zdyb2ima5qeeudqotxn@5zdxizip6mhb>
Date: Tue, 22 Oct 2024 22:27:43 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Melody Olvera <quic_molvera@...cinc.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Trilok Soni <quic_tsoni@...cinc.com>, 
	Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>, linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver

On Mon, Oct 21, 2024 at 04:04:14PM GMT, Melody Olvera wrote:
> Add initial pinctrl driver to support pin configuration with pinctrl

I think you should drop the word "initial", and perhaps insert "TLMM" in
its place.

> framework for sm8750 SoC.
> 
[..]
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8750.c b/drivers/pinctrl/qcom/pinctrl-sm8750.c
[..]
> +static const struct msm_pingroup sm8750_groups[] = {
[..]
> +	[215] = UFS_RESET(ufs_reset, 0xE2004, 0xE3000),

It would be nice if these digits where lower case...

> +	[216] = SDC_QDSD_PINGROUP(sdc2_clk, 0xDB000, 14, 6),
> +	[217] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xDB000, 11, 3),
> +	[218] = SDC_QDSD_PINGROUP(sdc2_data, 0xDB000, 9, 0),
> +};
> +
[..]
> +static const int sm8750_reserved_gpios[] = {
> +	36, 37, 38, 39, 74, -1

Any particular reason why these are not gpio-reserved-ranges in
DeviceTree?

Regards,
Bjorn

> +};
> +