linux-kernel - Re: [PATCH 1/7] kconfig: qconf: use QByteArray API instead of manually constructing a string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAT_LUBhg3aoX1iumO8vCoiLFfMTJ3xpDkHhM2A3U3HCyw@mail.gmail.com>
Date: Thu, 24 Oct 2024 04:07:41 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Rolf Eike Beer <eb@...ix.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] kconfig: qconf: use QByteArray API instead of
 manually constructing a string

On Thu, Oct 24, 2024 at 1:37 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Wed, Oct 23, 2024 at 3:29 PM Rolf Eike Beer <eb@...ix.com> wrote:
> >
> > Using a naked char[] here isn't necessary as QByteArray has a nice API for all
> > of this. Calling constData() will also always return a 0-terminated string so no
> > further handling is required. And then the whole manual memory handling can go
> > away as QByteArray will care for this when it goes out of scope.
> >
> > Signed-off-by: Rolf Eike Beer <eb@...ix.com>
> > ---
>
> I do not need this patch because I can refactor this function even deeper.
>
> I have locally kept several clean-up patches, but I have not got around to
> submitting them.
>
> I will send some of them later.


https://lore.kernel.org/linux-kbuild/20241023181823.138524-12-masahiroy@kernel.org/T/#u


-- 
Best Regards
Masahiro Yamada