linux-kernel - Re: [PATCH 1/7] kconfig: qconf: use QByteArray API instead of manually constructing a string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6093864.lOV4Wx5bFT@devpool47.emlix.com>
Date: Thu, 24 Oct 2024 09:02:19 +0200
From: Rolf Eike Beer <eb@...ix.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH 1/7] kconfig: qconf: use QByteArray API instead of manually
 constructing a string

On Mittwoch, 23. Oktober 2024 21:07:41 Mitteleuropäische Sommerzeit Masahiro 
Yamada wrote:
> On Thu, Oct 24, 2024 at 1:37 AM Masahiro Yamada <masahiroy@...nel.org> 
wrote:
> > On Wed, Oct 23, 2024 at 3:29 PM Rolf Eike Beer <eb@...ix.com> wrote:
> > > Using a naked char[] here isn't necessary as QByteArray has a nice API
> > > for all of this. Calling constData() will also always return a
> > > 0-terminated string so no further handling is required. And then the
> > > whole manual memory handling can go away as QByteArray will care for
> > > this when it goes out of scope.
> > > 
> > > Signed-off-by: Rolf Eike Beer <eb@...ix.com>
> > > ---
> > 
> > I do not need this patch because I can refactor this function even deeper.
> > 
> > I have locally kept several clean-up patches, but I have not got around to
> > submitting them.
> > 
> > I will send some of them later.
> 
> https://lore.kernel.org/linux-kbuild/20241023181823.138524-12-masahiroy@kern
> el.org/T/#u

Even better, thanks!
-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@...ix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
Download attachment "signature.asc" of type "application/pgp-signature" (314 bytes)