linux-kernel - Re: linux-next: Fixes tag needs some work in the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d057adb-c7e4-4324-a963-7fedc40ceed5@kernel.dk>
Date: Tue, 22 Oct 2024 19:14:15 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Bart Van Assche <bvanassche@....org>,
 Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 10/22/24 5:31 PM, Bart Van Assche wrote:
> On 10/22/24 3:59 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>    6fbd7e0472b7 ("blk-mq: Make blk_mq_quiesce_tagset() hold the tag list mutex less long")
>>
>> Fixes tag
>>
>>    Fixes: commit 414dd48e882c ("blk-mq: add tagset quiesce interface")
>>
>> has these problem(s):
>>
>>    - leading word 'commit' unexpected
> 
> Jens, please let me know if you want me to post a second version of that
> patch.

I fixed it up - for future reference, I recommend adding:

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")

to ~/.gitconfig and then you can just do:

axboe@...ax ~/gi/linux (for-next)> git fixes 414dd48e882c5a39e7bd01b096ee6497eb3314b0
Fixes: 414dd48e882c ("blk-mq: add tagset quiesce interface")

and get the correctly formatted line. Whenever people try and
make them up, they always get it slightly wrong.

-- 
Jens Axboe