linux-kernel - Re: [PATCH] iio: Fix build error for ltc2664

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f81545a095136cd64b1991bae4027ad1dfe9597f.camel@gmail.com>
Date: Wed, 23 Oct 2024 12:17:49 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>, Jinjie Ruan	
 <ruanjinjie@...wei.com>, jic23@...nel.org, lars@...afoo.de, 
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, 
	nuno.sa@...log.com, conor.dooley@...rochip.com,
 michael.hennerich@...log.com, 	anshulusr@...il.com, sunke@...inos.cn,
 kimseer.paller@...log.com, 	linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] iio: Fix build error for ltc2664

On Wed, 2024-10-23 at 10:41 +0200, Javier Carrasco wrote:
> On 23/10/2024 10:23, Jinjie Ruan wrote:
> > If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
> > 
> > 	riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in
> > function `ltc2664_probe':
> > 	ltc2664.c:(.text+0x714): undefined reference to
> > `__devm_regmap_init_spi'
> > 
> > Select REGMAP_SPI for LTC2664 to fix it.
> > 
> > Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and
> > LTC2672")
> > Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> > ---
> >  drivers/iio/dac/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> > index 45e337c6d256..ae6d04c758d1 100644
> > --- a/drivers/iio/dac/Kconfig
> > +++ b/drivers/iio/dac/Kconfig
> > @@ -381,6 +381,7 @@ config LTC2664
> >  	tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> >  	depends on SPI
> >  	select REGMAP
> > +	select REGMAP_SPI
> 
> Should you not replace REGMAP with REGMAP_SPI instead?

Yes, I think so... The commit title could also be improved

"iio: dac: kconfig: ..."

With that:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

> 
> 
> >  	help
> >  	  Say yes here to build support for Analog Devices
> >  	  LTC2664 and LTC2672 converters (DAC).
> 
> 
> Best regards,
> Javier Carrasco