linux-kernel - Re: [PATCH hotfix 6.12 0/8] fix error handling in mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec22d5b7-14e9-4df8-9e78-ca0af1b09930@lucifer.local>
Date: Wed, 23 Oct 2024 11:26:00 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH hotfix 6.12 0/8] fix error handling in mmap_region() and
 refactor

On Wed, Oct 23, 2024 at 03:22:36AM -0700, Andrew Morton wrote:
> On Tue, 22 Oct 2024 21:40:51 +0100 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
>
> > After this we go further, refactoring the code, placing it in mm/vma.c in
> > order to make it eventually userland testable, and significantly
> > simplifying the logic to avoid this issue arising in future.
>
> I'm not sure that patches 4-8 are strictly 6.12 material.  What's the
> thinking here?
>

Patch 4 is absolutely critical and without which 1-3 don't really matter
all that much. It also needs to be backported (I will be doing some manual
backports for that once landed).

Patches 5-8 could be held back to 6.13 if preferred as, while nice to have
as they do further work to eliminate this class of bugs, are not as
important.