linux-kernel - Re: [PATCH v2 3/5] rust: page: Extend support to vmalloc_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74db5f3b-c329-474e-9a9d-de67d7cb888c@gmail.com>
Date: Wed, 23 Oct 2024 13:26:37 +0300
From: Abdiel Janulgue <abdiel.janulgue@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: rust-for-linux@...r.kernel.org, aliceryhl@...gle.com, dakr@...hat.com,
 linux-kernel@...r.kernel.org, airlied@...hat.com,
 miguel.ojeda.sandonis@...il.com, boqun.feng@...il.com
Subject: Re: [PATCH v2 3/5] rust: page: Extend support to vmalloc_to_page

On 23/10/2024 11:42, Danilo Krummrich wrote:
>> +    ) -> Result<&'a Self, AllocError>
> 
> Please don't use `AllocError`. We're not allocating anything here.
> 
> Anyway, do we need this as a separate function at all?
Thanks. Would it make sense to squash this function into 
`Page::page_slice_to_page` instead?

/Abdiel