linux-kernel - Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for threads hash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CDE1D110-A3F5-4BB7-A8DF-4D24E2AC98B0@oracle.com>
Date: Wed, 23 Oct 2024 02:24:36 +0000
From: Anjali Kulkarni <anjali.k.kulkarni@...cle.com>
To: Stanislav Fomichev <stfomichev@...il.com>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        Liam Howlett
	<liam.howlett@...cle.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org"
	<peterz@...radead.org>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
        "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
        "rostedt@...dmis.org"
	<rostedt@...dmis.org>,
        "bsegall@...gle.com" <bsegall@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "vschneid@...hat.com"
	<vschneid@...hat.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "shuah@...nel.org"
	<shuah@...nel.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        Pei Li <peili.io@...cle.com>
Subject: Re: [PATCH net-next v5 2/3] connector/cn_proc: Kunit tests for
 threads hash table

[…snip…]

>>>> 
>>>> Yes, make sure all required options are picked up by
>>>> "./tools/testing/kunit/kunit.py run" instead of manually adding options
>>>> and doing modprobe.
>>> 
>>> The environment issues are resolved and I am able to run kunit.py, but my tests
>>> are not invoked without giving options via —kconfig-add. Other tests are also not
>>> invoked. Running with the manual options runs 413 tests, and with just kunit.py
>>> runs 389 tests. (I have added 6). Any idea how I can make it run my tests?
>> 
>> The runner does: ./tools/testing/kunit/kunit.py run --alltests
>> Is it not enough in your case? What options do you pass via
>> --kconfig-add? Is it because CONNECTOR stuff is disabled by default?
> 
> No, it still does not run.
> However, I added to tools/testing/kunit/configs/all_tests.config:
> 
> CONFIG_CONNECTOR=y
> CONFIG_PROC_EVENTS=y
> CONFIG_NET=y
> CONFIG_CN_HASH_KUNIT_TEST=y
> 
> And now it does run.
> Should I make the change above? I will also check with the kunit guys.
> But I do not understand how it ran for you(and run into the error), or did
> it just try to compile?

I see this in comments on top of all_tests.config.

# The config is manually maintained, though it uses KUNIT_ALL_TESTS=y to enable
# any tests whose dependencies are already satisfied. Please feel free to add
# more options if they any new tests.

So I suppose if a test needs more dependencies, it needs to be added here.

Anjali