linux-kernel - Re: [PATCH 3/3] block: model freeze & enter queue as lock for supporting lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023122251.GC28777@lst.de>
Date: Wed, 23 Oct 2024 14:22:51 +0200
From: Christoph Hellwig <hch@....de>
To: Ming Lei <ming.lei@...hat.com>
Cc: Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
	Christoph Hellwig <hch@....de>,
	Peter Zijlstra <peterz@...radead.org>,
	Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>,
	Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
	linux-kernel@...r.kernel.org, Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH 3/3] block: model freeze & enter queue as lock for
 supporting lockdep

On Wed, Oct 23, 2024 at 05:54:35PM +0800, Ming Lei wrote:
> Recently we got several deadlock report[1][2][3] caused by blk_mq_freeze_queue
> and blk_enter_queue().

Please wrap your commit logs a 73 characters.

> For example, the following lockdep report can be triggered in the
> report[3].

And I think the commit log would be a lot more readable without the
long trace.

The code itself looks good:

Reviewed-by: Christoph Hellwig <hch@....de>