linux-kernel - Re: [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1d30ad1-868a-480a-9601-32106e8d2baf@amd.com>
Date: Wed, 23 Oct 2024 14:50:15 +0200
From: Michal Simek <michal.simek@....com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Lars-Peter Clausen <lars@...afoo.de>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Vishal Sagar <vishal.sagar@....com>,
 Anatoliy Klymenko <anatoliy.klymenko@....com>,
 Péter Ujfalusi <peter.ujfalusi@...il.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio

Hi Tomi,

On 10/23/24 14:00, Tomi Valkeinen wrote:
> Hi Michal,
> 
> On 08/10/2024 11:22, Michal Simek wrote:
>>
>>
>> On 9/10/24 13:19, Tomi Valkeinen wrote:
>>> Add the two DMA channels used for the DisplayPort audio to the
>>> zynqmp_dpsub node.
>>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>>> ---
>>>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++++--
>>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/ dts/ 
>>> xilinx/zynqmp.dtsi
>>> index b1b31dcf6291..673ca8422e6b 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> @@ -1207,11 +1207,14 @@ zynqmp_dpsub: display@...a0000 {
>>>                         "dp_vtc_pixel_clk_in";
>>>               power-domains = <&zynqmp_firmware PD_DP>;
>>>               resets = <&zynqmp_reset ZYNQMP_RESET_DP>;
>>> -            dma-names = "vid0", "vid1", "vid2", "gfx0";
>>> +            dma-names = "vid0", "vid1", "vid2", "gfx0",
>>> +                    "aud0", "aud1";
>>>               dmas = <&zynqmp_dpdma ZYNQMP_DPDMA_VIDEO0>,
>>>                      <&zynqmp_dpdma ZYNQMP_DPDMA_VIDEO1>,
>>>                      <&zynqmp_dpdma ZYNQMP_DPDMA_VIDEO2>,
>>> -                   <&zynqmp_dpdma ZYNQMP_DPDMA_GRAPHICS>;
>>> +                   <&zynqmp_dpdma ZYNQMP_DPDMA_GRAPHICS>,
>>> +                   <&zynqmp_dpdma ZYNQMP_DPDMA_AUDIO0>,
>>> +                   <&zynqmp_dpdma ZYNQMP_DPDMA_AUDIO1>;
>>>               ports {
>>>                   #address-cells = <1>;
>>>
>>
>> Acked-by: Michal Simek <michal.simek@....com>
>>
>> If you want me to take this patch via my tree please let me know.
> 
> Thanks. I've sent a v4, but no changes to this patch.
> 
> I'm not sure what is the custom with xilinx dts changes. With the other 
> platforms dts changes have always gone through a single tree, not via driver trees.
> 
> I don't have a preference either way, so if there's no clear rule here, I can 
> take this one with the other patches.

I have seen it both ways. If this is done with patches it is easier because I 
can't really send it before dt binding patch reaches upstream. It means there is 
going to be delay.
Normally it should be enough that I gave you my tag that you can also change the 
DT files too.

Thanks,
Michal