linux-kernel - Re: [PATCH v4 7/7] arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS615

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ghvvsnf4xej4ylebxottza6xpina63b2sesz4v4laubi6euvqx@yqckh7hgkiit>
Date: Tue, 22 Oct 2024 21:42:19 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Lijuan Gao <quic_lijuang@...cinc.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, kernel@...cinc.com, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 7/7] arm64: defconfig: enable clock controller,
 interconnect and pinctrl for QCS615

On Tue, Oct 22, 2024 at 04:54:35PM GMT, Lijuan Gao wrote:
> Enable clock controller, interconnect and pinctrl for Qualcomm
> QCS615 platform to boot to UART console.
> 
> The serial engine depends on gcc, interconnect and pinctrl. Since
> the serial console driver is only available as built-in, so these
> configs needs be built-in for the UART device to probe and register
> the console.
> 

I love the fact that you're describing the reason for making these
built-in, and in such a clear way.


It therefor saddens me to say that there's more to it...

A builtin driver with module dependencies will through device links and
probe deferral be probed once those resources are available, so this
isn't the reason for us to mark these providers as built-in. Instead
what we're looking for is the fact that we want the console to be
registered before we launch userspace (and thereby load modules).

The main reason for this is that e.g. systemd opens /dev/console at
launch (i.e. when the init process starts). So if we registers the
console after this, we will not get the console output from systemd.


So, please rephrase this to state that we want these built-in, because
the serial console driver depends on them and we want that registered
before we launch userspace.

Regards,
Bjorn

> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 36b33b9f1704..fd0dfa9ebae0 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -607,6 +607,7 @@ CONFIG_PINCTRL_MSM8996=y
>  CONFIG_PINCTRL_MSM8998=y
>  CONFIG_PINCTRL_QCM2290=y
>  CONFIG_PINCTRL_QCS404=y
> +CONFIG_PINCTRL_QCS615=y
>  CONFIG_PINCTRL_QDF2XXX=y
>  CONFIG_PINCTRL_QDU1000=y
>  CONFIG_PINCTRL_SA8775P=y
> @@ -1323,6 +1324,7 @@ CONFIG_MSM_MMCC_8998=m
>  CONFIG_QCM_GCC_2290=y
>  CONFIG_QCM_DISPCC_2290=m
>  CONFIG_QCS_GCC_404=y
> +CONFIG_QCS_GCC_615=y
>  CONFIG_SC_CAMCC_7280=m
>  CONFIG_QDU_GCC_1000=y
>  CONFIG_SC_CAMCC_8280XP=m
> @@ -1629,6 +1631,7 @@ CONFIG_INTERCONNECT_QCOM_MSM8996=y
>  CONFIG_INTERCONNECT_QCOM_OSM_L3=m
>  CONFIG_INTERCONNECT_QCOM_QCM2290=y
>  CONFIG_INTERCONNECT_QCOM_QCS404=m
> +CONFIG_INTERCONNECT_QCOM_QCS615=y
>  CONFIG_INTERCONNECT_QCOM_QDU1000=y
>  CONFIG_INTERCONNECT_QCOM_SA8775P=y
>  CONFIG_INTERCONNECT_QCOM_SC7180=y
> 
> -- 
> 2.46.0
>