linux-kernel - Re: [PATCH] rust: irq: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=tywaM4n-6isLmpu5fC3uj5H7g4QfiaksXcaPH_Pfxaw@mail.gmail.com>
Date: Thu, 24 Oct 2024 17:05:30 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: irq: add support for request_irq()

Hi Daniel,

A couple procedural things on your latest patches (no need to send new
versions right away).

On Thu, Oct 24, 2024 at 4:20 PM Daniel Almeida
<daniel.almeida@...labora.com> wrote:
>
> Both regular and threaded versions are supported.

I am not sure if the commit message was truncated, but it should
explain why the change is done and what is being changed. For
instance, it should mention who will need this upstream. Please see
other similar patches/series we have, e.g. one of the latest ones in Lore:

    https://lore.kernel.org/rust-for-linux/20241022213221.2383-1-dakr@kernel.org/

> base-commit: 33c255312660653cf54f8019896b5dca28e3c580

Please try this one on top of `rust-next` -- you will get new Clippy
warnings about missing safety sections & comments.

Thanks!

Cheers,
Miguel