linux-kernel - Re: [PATCH] rust: irq: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <EF671774-94A4-43B2-B959-3ACFBE8F3FCE@collabora.com>
Date: Thu, 24 Oct 2024 12:08:22 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: irq: add support for request_irq()

Hi Miguel, yes, my bad.

> On 24 Oct 2024, at 12:05, Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
> 
> Hi Daniel,
> 
> A couple procedural things on your latest patches (no need to send new
> versions right away).
> 
> On Thu, Oct 24, 2024 at 4:20 PM Daniel Almeida
> <daniel.almeida@...labora.com> wrote:
>> 
>> Both regular and threaded versions are supported.
> 
> I am not sure if the commit message was truncated, but it should
> explain why the change is done and what is being changed. For
> instance, it should mention who will need this upstream. Please see
> other similar patches/series we have, e.g. one of the latest ones in Lore:
> 
>    https://lore.kernel.org/rust-for-linux/20241022213221.2383-1-dakr@kernel.org/
> 
>> base-commit: 33c255312660653cf54f8019896b5dca28e3c580
> 
> Please try this one on top of `rust-next` -- you will get new Clippy
> warnings about missing safety sections & comments.
> 
> Thanks!
> 
> Cheers,
> Miguel

— Daniel