linux-kernel - Re: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the end of structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <414ef7aa-a1a3-4c13-887b-25a51236f83e@gmail.com>
Date: Thu, 24 Oct 2024 06:22:09 +0200
From: Mirsad Todorovac <mtodorovac69@...il.com>
To: Bart Van Assche <bvanassche@....org>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Nilesh Javali <njavali@...vell.com>,
 GR-QLogic-Storage-Upstream@...vell.com,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the
 end of structures

On 10/24/24 00:25, Bart Van Assche wrote:
> On 10/23/24 3:17 PM, Mirsad Todorovac wrote:
>> Fixes: 21038b0900d1b ("scsi: qla2xxx: Fix endianness annotations in header files")
> 
> The "Fixes:" tag is wrong. The one-element arrays were introduced long
> before I fixed the endianness annotations.
> 
>> diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
>> index 54f0a412226f..ca9304df484b 100644
>> --- a/drivers/scsi/qla2xxx/qla_dbg.h
>> +++ b/drivers/scsi/qla2xxx/qla_dbg.h
>> @@ -31,7 +31,7 @@ struct qla2300_fw_dump {
>>       __be16 fpm_b1_reg[64];
>>       __be16 risc_ram[0xf800];
>>       __be16 stack_ram[0x1000];
>> -    __be16 data_ram[1];
>> +    __be16 data_ram[];
>>   };
>>   
> 
> How has this patch been tested? Has it even been compile-tested? This
> patch probably breaks at least the following statement:
> 
>     BUILD_BUG_ON(sizeof(struct qla2300_fw_dump) != 136100);
> 
> Thanks,
> 
> Bart.

>From next-20241023, it seems to have passed compilation:

  INSTALL debian/linux-libc-dev/usr/include
dpkg-deb: building package 'linux-image-6.12.0-rc4-next-20241023-00001-gdcf82889780d' in '../linux-image-6.12.0-rc4-next-20241023-00001-gdcf82889780d_6.12.0-rc4-00001-gdcf82889780d-4_amd64.deb'.
dpkg-deb: building package 'linux-libc-dev' in '../linux-libc-dev_6.12.0-rc4-00001-gdcf82889780d-4_amd64.deb'.
 dpkg-genbuildinfo --build=binary -O../linux-upstream_6.12.0-rc4-00001-gdcf82889780d-4_amd64.buildinfo
 dpkg-genchanges --build=binary -O../linux-upstream_6.12.0-rc4-00001-gdcf82889780d-4_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)

Perhaps I should have told that it was from the linux-next tree.

Best regards,
Mirsad