linux-kernel - Re: [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241024184634.3bfcde82@jic23-huawei>
Date: Thu, 24 Oct 2024 18:46:34 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: <lars@...afoo.de>, <paul.walmsley@...ive.com>, <palmer@...belt.com>,
 <aou@...s.berkeley.edu>, <nuno.sa@...log.com>,
 <javier.carrasco.cruz@...il.com>, <sunke@...inos.cn>,
 <conor.dooley@...rochip.com>, <anshulusr@...il.com>,
 <kimseer.paller@...log.com>, <michael.hennerich@...log.com>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-riscv@...ts.infradead.org>, <noname.nuno@...il.com>
Subject: Re: [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664

On Thu, 24 Oct 2024 09:55:53 +0800
Jinjie Ruan <ruanjinjie@...wei.com> wrote:

> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
> 
> 	riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> 	ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
> 
> Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.
> 
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
Applied to the fixes-togreg branch of iio.git 
Thanks,

Jonathan

> ---
> v2:
> - Select REGMAP_SPI instead of REGMAP.
> - Update the commit subject.
> - Add Reviewed-by.
> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..9f5d5ebb8653 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -380,7 +380,7 @@ config LTC2632
>  config LTC2664
>  	tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
>  	depends on SPI
> -	select REGMAP
> +	select REGMAP_SPI
>  	help
>  	  Say yes here to build support for Analog Devices
>  	  LTC2664 and LTC2672 converters (DAC).