[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a3d6b2b9-1379-4bab-a584-651ca66677ee@notapiano>
Date: Thu, 24 Oct 2024 13:46:38 -0400
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Sean Wang <sean.wang@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Bamvor Jian Zhang <bamv2005@...il.com>,
Shuah Khan <shuah@...nel.org>, kernel@...labora.com,
linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kselftest@...r.kernel.org, kernelci@...ts.linux.dev
Subject: Re: [PATCH RFC 1/3] pinctrl: mediatek: paris: Expose more
configurations to GPIO set_config
On Thu, Oct 24, 2024 at 05:17:05PM +0200, AngeloGioacchino Del Regno wrote:
> Il 11/09/24 12:10, AngeloGioacchino Del Regno ha scritto:
> > Il 09/09/24 20:37, Nícolas F. R. A. Prado ha scritto:
> > > Currently the set_config callback in the gpio_chip registered by the
> > > pinctrl_paris driver only supports PIN_CONFIG_INPUT_DEBOUNCE, despite
> >
> > [...] only supports operations configuring the input debounce parameter
> > of the EINT controller and denies configuring params on the other AP GPIOs [...]
> >
> > (reword as needed)
> >
> > > many other configurations already being implemented and available
> > > through the pinctrl API for configuration of pins by the Devicetree and
> > > other drivers.
> > >
> > > Expose all configurations currently implemented through the GPIO API so
> > > they can also be set from userspace, which is particularly useful to
> > > allow testing them from userspace.
> > >
> > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > > ---
> > > drivers/pinctrl/mediatek/pinctrl-paris.c | 20 ++++++++++----------
> >
> > You can do the same for pinctrl-moore too, it's trivial.
> >
> > Other than that, I agree about performing this change, as this may be useful
> > for more than just testing.
> >
>
> Nicolas, please don't forget to respin this patch.
I was hoping to get some feedback on the test itself as well, particularly from
Linus as the pinctrl maintainer, but it's also been a while so I'll send a v2
with the feedback here addressed.
Thanks,
Nícolas
Powered by blists - more mailing lists