[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241024010103.238ef40b@rorschach.local.home>
Date: Thu, 24 Oct 2024 01:01:03 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Michael Ellerman <mpe@...erman.id.au>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Christoph Hellwig
<hch@...radead.org>, Kees Cook <kees@...nel.org>, Sasha Levin
<sashal@...nel.org>, torvalds@...ux-foundation.org,
ksummit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: linus-next: improving functional testing for to-be-merged pull
requests
On Thu, 24 Oct 2024 14:59:16 +1100
Michael Ellerman <mpe@...erman.id.au> wrote:
> > But pushing to linux-next for a day or two, what does that give me?
>
> Several thousand build tests, across pretty much every architecture.
>
> And a few hundred boot tests, lots virtualised, but some on real HW.
>
> A single character typo in an #ifdef your testing doesn't cover can
> break the build for lots of people ...
I use to get that from the zero-day bot from intel. Does that not run
anymore? I noticed that I don't get notifications anymore.
So yeah, my work flow is to push to my "urgent" branch, and wait a day
for the zero-day bot. But if that's no longer the case, then maybe I
can ask Stephen to take my urgent branches.
Now the issue here is that I push to my urgent branches *before* I run
my tests. That's because my tests take 8 - 13 hours and I want the
zero-day bot to get a head start. When a bug was in my code, both my
tests and the zero-day bot would catch it. I would check to see which
one found it first. Sometimes it was my tests, sometimes the bot.
Now the issue is, if a bug is found. I don't change the branch I pushed
up. Thus, if its broken, it will stay broken until I get around to
fixing it. Depending on how badly it is broken, it may be several days
before its fixed. I would imagine if this branch is now in next, it
would break next and burden Stephen to revert my branch until its
fixed. Or it will change my workflow to have to either push after it
passes my tests or revert what I pushed first. I'm guessing I would
have to now push after my tests pass (if zero-day is no longer working).
As for the linus-next (linus-pr), this is a case that could work with
my workflow. I would happily sign up, and when I do my git pull, have
a bot pull my code into this tree (along with all the other pull
request for the day) run all these tests, and then Linus can pull after
they all passed.
-- Steve
Powered by blists - more mailing lists