linux-kernel - Re: [PATCH] driver core: constify devlink class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx9GfFsfWymBvXHs7F0S_mvK=eCy=q8-gBu1UPm9QzNVgQ@mail.gmail.com>
Date: Thu, 24 Oct 2024 12:54:06 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] driver core: constify devlink class

On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > The devlink class object is never modified and can be made constant.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Acked-by: Rafael J. Wysocki <rafael@...nel.org>

Acked-by: Saravana Kannan <saravanak@...gle.com>

-Saravana

>
> > ---
> >  drivers/base/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index a84a7b952cfd..0e618d675792 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> >  }
> >  EXPORT_SYMBOL_GPL(device_link_wait_removal);
> >
> > -static struct class devlink_class = {
> > +static const struct class devlink_class = {
> >         .name = "devlink",
> >         .dev_groups = devlink_groups,
> >         .dev_release = devlink_dev_release,
> > --
> > 2.43.0
> >