linux-kernel - Re: [PATCH] driver core: constify devlink class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdxxfhXw8JP9We5Ty_gpiU+G9mUD2mgfPoQm8gaE=CX=A@mail.gmail.com>
Date: Thu, 31 Oct 2024 13:31:43 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Saravana Kannan <saravanak@...gle.com>
Subject: Re: [PATCH] driver core: constify devlink class

On Thu, Oct 24, 2024 at 9:54 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
> >
> > On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > The devlink class object is never modified and can be made constant.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Acked-by: Rafael J. Wysocki <rafael@...nel.org>
>
> Acked-by: Saravana Kannan <saravanak@...gle.com>
>
> -Saravana
>
> >
> > > ---
> > >  drivers/base/core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > index a84a7b952cfd..0e618d675792 100644
> > > --- a/drivers/base/core.c
> > > +++ b/drivers/base/core.c
> > > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > >  }
> > >  EXPORT_SYMBOL_GPL(device_link_wait_removal);
> > >
> > > -static struct class devlink_class = {
> > > +static const struct class devlink_class = {
> > >         .name = "devlink",
> > >         .dev_groups = devlink_groups,
> > >         .dev_release = devlink_dev_release,
> > > --
> > > 2.43.0
> > >

Greg, can you pick this one up please?

Bart